[PATCH V9 05/13] powerpc, perf: Change name & type of 'pred' in power_pmu_bhrb_read

Anshuman Khandual khandual at linux.vnet.ibm.com
Thu Jun 25 22:52:08 AEST 2015


On 06/25/2015 10:41 AM, Daniel Axtens wrote:
>> 				cpuhw->bhrb_entries[u_index].to = addr;
>> -				cpuhw->bhrb_entries[u_index].mispred = pred;
>> -				cpuhw->bhrb_entries[u_index].predicted = ~pred;
>> +				cpuhw->bhrb_entries[u_index].mispred = mispred;
>> +				cpuhw->bhrb_entries[u_index].predicted =
>> +								~mispred;
>>  
> 
> This is much better! However, these are still bitwise rather than
> logical inversions. They will work, but would it be easier to understand
> if you used "!mispred"?

Sure, will change it as well.



More information about the Linuxppc-dev mailing list