[PATCH V9 05/13] powerpc, perf: Change name & type of 'pred' in power_pmu_bhrb_read

Daniel Axtens dja at axtens.net
Thu Jun 25 15:11:14 AEST 2015


> 				cpuhw->bhrb_entries[u_index].to = addr;
> -				cpuhw->bhrb_entries[u_index].mispred = pred;
> -				cpuhw->bhrb_entries[u_index].predicted = ~pred;
> +				cpuhw->bhrb_entries[u_index].mispred = mispred;
> +				cpuhw->bhrb_entries[u_index].predicted =
> +								~mispred;
>  

This is much better! However, these are still bitwise rather than
logical inversions. They will work, but would it be easier to understand
if you used "!mispred"?

-- 
Regards,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 860 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20150625/b3dc0803/attachment.sig>


More information about the Linuxppc-dev mailing list