[PATCH] powerpc/opal: add warning for unimplemented OPAL message type

wen.pu at powercore.com.cn wen.pu at powercore.com.cn
Tue Dec 8 18:30:13 AEDT 2015


I found that there are unimplemented OPAL message types "OPAL_MSG_EPOW" and 
"OPAL_MSG_DPO" in PowerNV Platform. If skiboot send such messages to kernel, 
nothing will happen(notifier_call_chain() will silently drop it). So I add a warning 
to inform what has happened, is it necessary? 

Signed-off-by: Wen Pu <wen.pu at powercore.com.cn>
---
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index f084afa..ef498ab 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -281,6 +281,10 @@ static void opal_handle_message(void)
  pr_warning("%s: Unknown message type: %u\n", __func__, type);
  return;
  }
+ if(type == OPAL_MSG_EPOW || type == OPAL_MSG_DPO) {
+ pr_warning("%s: Unimplemented message type: %u\n", __func__, type);
+ return;
+ }
  opal_message_do_notify(type, (void *)&msg);
 }
---

Thanks!
Wen Pu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20151208/ffa4044b/attachment.html>


More information about the Linuxppc-dev mailing list