<html><head><meta http-equiv="content-type" content="text/html; charset=GB2312"><style>body { line-height: 1.5; }body { font-size: 10.5pt; font-family: ΢ÈíÑźÚ; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><body>
<div><span></span>I found that there are unimplemented <span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">OPAL message types "</span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">OPAL_MSG_EPOW</span><span style="background-color: window; font-size: 10.5pt; line-height: 1.5;">" and </span></div><div><span style="background-color: window; font-size: 10.5pt; line-height: 1.5;">"</span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">OPAL_MSG_DPO</span><span style="background-color: window; font-size: 10.5pt; line-height: 1.5;">" </span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">in PowerNV Platform. </span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">If skiboot send such messages to kernel, </span></div><div><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">nothing will happen(</span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">notifier_call_chain() will silently drop it</span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">). So I add a warning </span></div><div><span style="background-color: window; font-size: 10.5pt; line-height: 1.5;">to inform </span><span style="background-color: window; font-size: 10.5pt; line-height: 1.5;">what has happened, is it necessary? </span></div><div><br></div><div>Signed-off-by: Wen Pu <<span style="color: rgb(0, 0, 238); text-decoration: underline;">wen.pu@powercore.com.cn</span>></div><div>---</div><div>diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c<br>index f084afa..ef498ab 100644<br>--- a/arch/powerpc/platforms/powernv/opal.c<br>+++ b/arch/powerpc/platforms/powernv/opal.c<br>@@ -281,6 +281,10 @@ static void opal_handle_message(void)<br> <span style="white-space: pre;"> </span><span style="white-space: pre;"> </span>pr_warning("%s: Unknown message type: %u\n", __func__, type);<br> <span style="white-space: pre;"> </span><span style="white-space: pre;"> </span>return;<br> <span style="white-space: pre;"> </span>}<br>+<span style="white-space: pre;"> </span>if(type == OPAL_MSG_EPOW || type == OPAL_MSG_DPO) {<br>+<span style="white-space: pre;"> </span><span style="white-space: pre;"> </span>pr_warning("%s: Unimplemented message type: %u\n", __func__, type);<br>+<span style="white-space: pre;"> </span><span style="white-space: pre;"> </span>return;<br>+<span style="white-space: pre;"> </span>}<br> <span style="white-space: pre;"> </span>opal_message_do_notify(type, (void *)&msg);<br> }</div><div>---<br></div>
<div><br></div><div>Thanks!</div><div>Wen Pu</div>
</body></html>