[PATCH] QorIQ/TMU: add TMU node to device tree for QorIQ T104x

[Hongtao Jia]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, April 10, 2015 11:56 AM
> To: Jia Hongtao-B38951
> Cc: linuxppc-dev at lists.ozlabs.org; devicetree at vger.kernel.org;
> robh+dt at kernel.org; rui.zhang at intel.com
> Subject: Re: [PATCH] QorIQ/TMU: add TMU node to device tree for QorIQ
> T104x
> 
> On Tue, 2015-03-31 at 14:17 +0800, Jia Hongtao wrote:
> > This is Thermal Monitoring Unit for QorIQ platform.
> >
> > Signed-off-by: Jia Hongtao <hongtao.jia at freescale.com>
> > ---
> >  .../devicetree/bindings/thermal/qoriq-thermal.txt  | 58
> +++++++++++++++
> >  arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi   | 82
> ++++++++++++++++++++++
> >  arch/powerpc/boot/dts/fsl/t1040si-post.dtsi        |  1 +
> >  3 files changed, 141 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> >  create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> >
> > diff --git
> > a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > new file mode 100644
> > index 0000000..dfc17fa
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> > @@ -0,0 +1,58 @@
> > +* Thermal Monitoring Unit (TMU) on Freescale QorIQ SoCs
> > +
> > +Required properties:
> > +- compatible : "fsl,qoriq-tmu".
> 
> compatible: Must include "fsl,qoriq-tmu". The version of the device is
> 	    determined by the TMU IP Block Revision Register (IPBRR0)
> 	    at offset 0x0BF8.
> 
> 	    Table of correspondences between IPBRR0 values and example
> 	    chips:
> 		Value           Device
> 		-----------     -------
> 		0x01900102      T1040

I will update it in next version.

> 
> > +- reg : address range of TMU registers.
> > +- interrupts : should contain the interrupt for TMU.
> 
> s/should contain/contains/

Thanks for the correction.

> 
> > +- calibration : calibration table for TMU.
> 
> What is the format of the calibration table, and where does one get the
> data?

There are four calibration config range, for each range we got a couple of
pairs formatted like <TTCFGR, TSCFGR> at offset of <0x0080, 0x0084>.

-Hongtao

> 
> -Scott
>