[PATCH] powerpc/pci: reorder pci bus/bridge unregistration during PHB removal

Tyrel Datwyler tyreld at linux.vnet.ibm.com
Wed Jul 30 03:54:47 EST 2014

On 07/28/2014 06:44 PM, Michael Ellerman wrote:
> On Mon, 2014-07-28 at 20:48 -0400, Tyrel Datwyler wrote:
>> Commit bcdde7e made __sysfs_remove_dir() recursive and introduced a BUG_ON
>> during PHB removal while attempting to delete the power managment attribute
>> group of the bus. This is a result of tearing the bridge and bus devices down
>> out of order in remove_phb_dynamic. Since, the the bus resides below the bridge
>> in the sysfs device tree it should be torn down first.
>> This patch simply moves the device_unregister call for the PHB bridge device
>> after the device_unregister call for the PHB bus.
>> Signed-off-by: Tyrel Datwyler <tyreld at linux.vnet.ibm.com>
> That commit went into 3.13, so shouldn't this be CC to stable?

Darn it. Yes, it should.

> And also:
>   Fixes: bcdde7e221a8 ("sysfs: make __sysfs_remove_dir() recursive")
> cheers

More information about the Linuxppc-dev mailing list