[PATCH 1/2] powerpc/powernv: Change BUG_ON to WARN_ON in elog code

Stewart Smith stewart at linux.vnet.ibm.com
Wed Jul 23 22:15:06 EST 2014


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> We can continue to read the error log (up to MAX size) even if
> we get the elog size more than MAX size. Hence change BUG_ON to
> WARN_ON.
>
> Also updated error message.
>
> Reported-by: Gopesh Kumar Chaudhary <gopchaud at in.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Signed-off-by: Ananth N Mavinakayanahalli <ananth at in.ibm.com>
> Acked-by: Deepthi Dharwar <deepthi at linux.vnet.ibm.com>

So, it turns out the BUG_ON actually caught an FSP bug, at the very
least in their documentation.

The WARN_ON is probably the best thing we can do, along with the
OPAL/skiboot side fixes that I've mentioned separately.

Acked-by: Stewart Smith <stewart at linux.vnet.ibm.com>



More information about the Linuxppc-dev mailing list