[PATCH] powerpc/pseries: dynamically added OF nodes need to call of_node_init

Tyrel Datwyler tyreld at linux.vnet.ibm.com
Fri Jul 11 04:36:04 EST 2014

On 07/09/2014 07:33 PM, Michael Ellerman wrote:
> On Wed, 2014-07-09 at 21:20 -0400, Tyrel Datwyler wrote:
>> Commit 75b57ecf9 refactored device tree nodes to use kobjects such that they
>> can be exposed via /sysfs. A secondary commit 0829f6d1f furthered this rework
>> by moving the kobect initialization logic out of of_node_add into its own
>> of_node_init function. The inital commit removed the existing kref_init calls
>> in the pseries dlpar code with the assumption kobject initialization would
>> occur in of_node_add. The second commit had the side effect of triggering a
>> BUG_ON as a result of dynamically added nodes being uninitialized.
> So does this mean DLPAR is broken since 0829f6d1f (3.15-rc1)?

Yes, as well as suspend and migration.

> If so this should have a Cc: stable at kernel.org shouldn't it?

Doh, right you are.

> And the latest trend is to also add:
> Fixes: 0829f6d1f69e ("of: device_node kobject lifecycle fixes")

Got it. Will resend v2.


> cheers
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

More information about the Linuxppc-dev mailing list