[3/3,v4] powerpc/t2080rdb: Add T2080RDB board support

Scott Wood scottwood at freescale.com
Tue Jul 8 08:16:27 EST 2014


On Mon, 2014-07-07 at 05:26 -0500, Liu Shengzhou-B36685 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, June 26, 2014 7:35 AM
> > To: Liu Shengzhou-B36685
> > Cc: linuxppc-dev at lists.ozlabs.org
> > Subject: Re: [3/3,v4] powerpc/t2080rdb: Add T2080RDB board support
> > 
> > On Wed, Jun 11, 2014 at 06:10:06PM +0800, Shengzhou Liu wrote:
> > > +				i2c at 0 {
> > > +					#address-cells = <1>;
> > > +					#size-cells = <0>;
> > > +					reg = <0x0>;
> > > +
> > > +					sfp at 50 {
> > > +						compatible = "optics,sfp";
> > > +						reg = <0x50>;
> > > +					};
> > > +				};
> > 
> > What is "sfp"?  Please use generic node names when possible.
> > 
> > I'm not able to easily find what chip this is referring to by googling
> > "optics sfp".  I suspect this compatible is too vague -- what is the
> > actual part number?  Could you provide a URL to a description of the chip?
> > 
> > If "optics" is the correct vendor name, it needs to go into vendor-prefixes.txt.
> > 
> > -Scott
>
> [Shengzhou] SFP is "Small Form-factor Pluggable transceiver" for 10Gpbs
> optics module.  Actually, there is no a specific vendor for this case,
> it is a general sfp cage to which we can plug in different optics
> module from different vendors.  And there is no need to configure it by
> SW.  

Do not put arbitrary things in the vendor prefix.

What is the programming interface that is made available on i2c port
0x50?  If it can change based on user configuration, then perhaps it
should just be left out.

-Scott




More information about the Linuxppc-dev mailing list