[PATCH 1/3] iommu/fsl: Fix PAMU window size check.

Varun Sethi Varun.Sethi at freescale.com
Wed Jul 2 18:58:45 EST 2014


Thanks Emil.

> -----Original Message-----
> From: Emil Medve [mailto:Emilian.Medve at Freescale.com]
> Sent: Wednesday, July 02, 2014 1:16 PM
> To: Sethi Varun-B16395; iommu at lists.linux-foundation.org;
> joro at 8bytes.org; linux-kernel at vger.kernel.org; linuxppc-
> dev at lists.ozlabs.org; alex.williamson at redhat.com
> Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
> 
> On 06/24/2014 08:57 AM, Varun Sethi wrote:
> > is_power_of_2 requires an unsigned long parameter which would lead to
> > truncation of 64 bit values on 32 bit architectures.
> >
> > __ffs also expects an unsigned long parameter thus won't work for 64
> > bit values on 32 bit architectures.
> >
> > Signed-off-by: Varun Sethi <Varun.Sethi at freescale.com>
> > ---
> >  drivers/iommu/fsl_pamu.c        |    8 ++++----
> >  drivers/iommu/fsl_pamu_domain.c |    2 +-
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> Tested-by: Emil Medve <Emilian.Medve at Freescale.com>
> 
> On a P4080 DS (i.e. 32-bit SoC)
> 
> 
> Cheers,


More information about the Linuxppc-dev mailing list