[PATCH 0/2] Fix smp_processor_id() in preemptible splat
paul.gortmaker at windriver.com
Wed Apr 30 05:25:15 EST 2014
This seems to have been around for a while; I tripped over it while
working on testing 3.10-rt with Steven, and then confirmed it still
was an issue on today's mainline. (didn't check -next however...)
I didn't bisect, but it looks like it may have come in from the
changes in v3.9-rc1~100^2~57. It probably only impacts the older
cores like the 74xx that don't have CONFIG_HAVE_HW_BREAKPOINT,
and I know I haven't booted my sbc8641D in over a year, so no
surprise this went undetected for a while. Maybe adding a Cc:
stable is warranted?
It is pretty hard to ignore the splats since you get one per process,
so it must be just the older platform never getting much testing.
The 1st patch is just a small cleanup that makes the 2nd patch
a bit smaller.
If the __set_breakpoint() addition isn't liked, then we could
alternatively just wrap the one call site with preempt_dis/en/able.
Paul Gortmaker (2):
powerpc: drop return value from set_breakpoint as it is unused
powerpc: fix smp_processor_id() in preemptible splat in set_breakpoint
arch/powerpc/include/asm/debug.h | 3 ++-
arch/powerpc/include/asm/hw_breakpoint.h | 2 +-
arch/powerpc/kernel/hw_breakpoint.c | 8 ++++----
arch/powerpc/kernel/process.c | 15 +++++++++++----
arch/powerpc/kernel/signal.c | 2 +-
arch/powerpc/xmon/xmon.c | 2 +-
6 files changed, 20 insertions(+), 12 deletions(-)
More information about the Linuxppc-dev