[PATCH v2 1/2] powerpc/pm: add api to get suspend state which is STANDBY or MEM
Rafael J. Wysocki
rjw at rjwysocki.net
Wed Apr 30 09:07:44 EST 2014
On Tuesday, April 29, 2014 05:47:12 PM Scott Wood wrote:
> On Mon, 2014-04-28 at 13:53 +0800, Leo Li wrote:
> > On Sat, Apr 26, 2014 at 5:45 AM, Scott Wood <scottwood at freescale.com> wrote:
> > > On Thu, 2014-04-24 at 14:11 +0800, Dongsheng Wang wrote:
> > >> From: Wang Dongsheng <dongsheng.wang at freescale.com>
> > >>
> > >> Add set_pm_suspend_state & pm_suspend_state functions to set/get
> > >> suspend state. When system going to sleep or deep sleep, devices
> > >> can get the system suspend state(STANDBY/MEM) through pm_suspend_state
> > >> function and to handle different situations.
> > >>
> > >> Signed-off-by: Wang Dongsheng <dongsheng.wang at freescale.com>
> > >> ---
> > >> *v2*
> > >> Move pm api from fsl platform to powerpc general framework.
> > >
> > > What is powerpc-specific about this?
> > Generally I agree with you. But I had the discussion about this topic
> > a while ago with the PM maintainer. He suggestion to go with the
> > platform way.
> > https://lkml.org/lkml/2013/8/16/505
> If what he meant was whether you could do what this patch does, then you
> can answer him with, "No, because it got nacked as not being platform or
> arch specific." Oh, and you're still using .valid as the hook to set
> the platform state, which is awful -- I think .begin is what you want to
> If we did it in powerpc code, then what would we do on ARM? Copy the
> code? No.
> Now, a more legitimate objection to putting it in generic code might be
> that "standby" and "mem" are loosely defined and the knowledge of how a
> driver should react to each is platform specific -- but your patch
> doesn't address that. You still have the driver itself interpret what
> "standby" and "mem" mean.
> As for "in analogy with ACPI suspend operations", can someone familiar
> with ACPI explain what is meant?
ACPI defines sleep states S3 and S1 which are mappend to "mem" and
"standby" currently, but that may change in the future.
Generally speaking the meaning of "mem" and "standby" is platform-specific
except that "mem" should be a deeper (lower-power) sleep state than "standby".
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
More information about the Linuxppc-dev