[PATCH 1/2] powerpc/powernv: clear the refcount for pci_dev on powernv platform

Wei Yang weiyang at linux.vnet.ibm.com
Tue Apr 22 19:44:56 EST 2014


On Tue, Apr 22, 2014 at 06:25:09PM +1000, Benjamin Herrenschmidt wrote:
>On Tue, 2014-04-22 at 15:44 +0800, Wei Yang wrote:
>> So this patch(the 2nd one) doesn't contribute to clear the warning and
>> error.
>> Only the first patch did it. Please ignore this one.
>
>But is it correct ? It's not right to keep a refcount elevated if we
>don't have to.

The code refcount is introduced in commit 184cd4a3(powerpc/powernv: PCI
support for p7IOC under OPAL v2). To me, it looks not necessary.

>
>Gavin, can you get to the bottom of that refcount business ?
>
>Cheers,
>Ben.
>

-- 
Richard Yang
Help you, Help me



More information about the Linuxppc-dev mailing list