[PATCH 3/3] of: Handle memory at 0 node on PPC32 only
robherring2 at gmail.com
Mon Apr 21 22:56:22 EST 2014
On Fri, Apr 18, 2014 at 7:59 AM, Leif Lindholm <leif.lindholm at linaro.org> wrote:
> Hi Geert,
> On Fri, Apr 18, 2014 at 10:04:15AM +0200, Geert Uytterhoeven wrote:
>> On Thu, Apr 17, 2014 at 7:42 PM, Leif Lindholm <leif.lindholm at linaro.org> wrote:
>> > In order to deal with an firmware bug on a specific ppc32 platform
>> > (longtrail), early_init_dt_scan_memory() looks for a node called
>> > memory at 0 on all platforms. Restrict this quirk to ppc32 kernels only.
>> This breaks backwards compatibilty with old DTSes (at least on ARM/MIPS,
>> where you added the missing property in patches 1 and 2 of the series)?
> As Rob said in response to 0/3, the MIPSs would likely not be affected,
> since they embed the DT.
>> For the Longtrail, I don't care much anymore, as mine died in 2004.
>> AFAIK, there have never been many users anyway.
> There are still a few mentions of it under arch/powerpc/, so I wouldn't
> want to be the one to kill it off...
> How about the below v2 3/3 to address the ARM platform?
> From 6fa0b837ad71780334eb97d63c507165b6c57add Mon Sep 17 00:00:00 2001
> From: Leif Lindholm <leif.lindholm at linaro.org>
> Date: Thu, 17 Apr 2014 14:24:47 +0100
> Subject: [PATCH] of: arm: powerpc: Restrict memory at 0 node handling to
> affected platforms
> In order to deal with a firmware bug on a specific ppc32 platform
> (longtrail), early_init_dt_scan_memory() looks for a node called
> memory at 0 on all platforms, for all nodes lacking a device_type.
> Restrict this quirk to ppc32 and the arm mach-ux500 platforms (one of
> which has depended on this special handling).
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 889005f..230c747 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -77,4 +77,7 @@ config OF_RESERVED_MEM
> Helpers to allow for reservation of memory regions
> +config OF_MEMORY_AT_0_QUIRK
> + def_bool n
I do not like this because it would not scale to many quirks. As I
said,, my preference here would be to just add a WARN.
The other option is get approval to break compatibility on the ST
platform. It may not be a concern on certain platforms.
More information about the Linuxppc-dev