[PATCH v3] dmaengine: driver support for FSL RaidEngine device.
xuelin.shi at freescale.com
Tue Apr 15 13:07:59 EST 2014
Yes, "depend on !ASYNC_TX_CHANNEL_SWITCH" is better since fsldma selects this condition.
From: Dan Williams [mailto:dan.j.williams at intel.com]
Sent: 2014年4月15日 8:30
To: Shi Xuelin-B29237
Cc: Koul, Vinod; andriy.shevchenko at intel.com; dmaengine at vger.kernel.org; linuxppc-dev; Rai Harninder-B01044; Burmi Naveen-B16502
Subject: Re: [PATCH v3] dmaengine: driver support for FSL RaidEngine device.
On Sun, Apr 13, 2014 at 7:48 PM, Xuelin Shi <xuelin.shi at freescale.com> wrote:
> Hi Dan,
> fsl dma device and fsl raid device are two differenct devices that
> both provide async_memcpy capability, so I use !FSL_DMA to disable the fsl dma device.
> That's to say, either select fsldma device, either fsl raid device.
Right, but that's not what your proposed Kconfig dependency line does.
You want something like "depends on FSL_SOC && !(FSL_DMA || FSL_DMA=m)"
However, the more problematic option is ASYNC_TX_CHANNEL_SWITCH. That option is problematic for RAID, so I propose "depend on !ASYNC_TX_CHANNEL_SWITCH" since that addresses both problems.
More information about the Linuxppc-dev