[PATCH] powerpc: Fix error return in rtas_flash module init
Anton Blanchard
anton at samba.org
Mon Apr 14 21:23:32 EST 2014
module_init should return 0 or a negative errno.
Signed-off-by: Anton Blanchard <anton at samba.org>
---
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
index 2f3cdb0..658e89d 100644
--- a/arch/powerpc/kernel/rtas_flash.c
+++ b/arch/powerpc/kernel/rtas_flash.c
@@ -705,7 +705,7 @@ static int __init rtas_flash_init(void)
if (rtas_token("ibm,update-flash-64-and-reboot") ==
RTAS_UNKNOWN_SERVICE) {
pr_info("rtas_flash: no firmware flash support\n");
- return 1;
+ return -EINVAL;
}
rtas_validate_flash_data.buf = kzalloc(VALIDATE_BUF_SIZE, GFP_KERNEL);
More information about the Linuxppc-dev
mailing list