[PATCH 2/2] Make the diu driver work without board level initilization

Jason.Jin at freescale.com Jason.Jin at freescale.com
Wed Apr 2 11:22:58 EST 2014


> > Thanks, This has been fixed in the update version, please help to
> review it at:
> > http://patchwork.ozlabs.org/patch/335225/
> > I forgot to add the V2 information in the subject in the update patch
> so this may confuse the reviewer, sorry for that.
> 
> It is not fixed in that patch (or did you link the wrong version?).  You
> should never use \ to continue a line in C, other than in macros.
> 
> Further, it is not permitted to wrap kernel output strings.  This is an
> exception to the 80-column rule.  Checkpatch should have told you this.
[Jason Jin-R64188] Thanks for pointing out this, I confused the internal version and external version. I'll fix it in next version. Thanks.


More information about the Linuxppc-dev mailing list