[PATCH V3 2/2] powerpc/85xx: Add TWR-P1025 board support

[Xie Xiaobo-R63061]

Hi Scott,

I discuss it with Liu Shengzhou again. I tried interrupts = <1 1 0 0> instead of interrupts = <1 1> on P1025TWR, and it's OK. So I will add 2 cells for the interrupts property. Thank you.

Best Regards
Xie Xiaobo
-----Original Message-----
From: Wood Scott-B07421 
Sent: Friday, September 06, 2013 11:26 PM
To: Xie Xiaobo-R63061
Cc: Wood Scott-B07421; linuxppc-dev at lists.ozlabs.org; galak at kernel.crashing.org; Johnston Michael-R49610
Subject: Re: [PATCH V3 2/2] powerpc/85xx: Add TWR-P1025 board support

On Fri, 2013-09-06 at 05:01 -0500, Xie Xiaobo-R63061 wrote:
> Hi Scott,
> 
> Thanks for your reminding and advice.
> 
> I discuss this with Liu Shengzhou(the first person that remind me 
> #interrupt-cells is 4), he advised removing the interrupts property 
> from the phy node, because the mdio used the poll way preferentially.

I don't follow... if the PHYs have interrupts, why would we prefer to poll?

In any case, the device tree describes the hardware, not how you'd prefer to use it.

-Scott