[PATCH V3 2/2] powerpc/85xx: Add TWR-P1025 board support

[Liu Shengzhou-B36685]

Xiaobo,

You can use interrupts = <1 1 0 0> instead of interrupts = <1 1> with test on P1025twr.
It was mislead by hardware issue on p1010rdb-pb board.

Regards,
Shengzhou

> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+shengzhou.liu=freescale.com at lists.ozlabs.org] On Behalf Of Xie Xiaobo-
> R63061
> Sent: Friday, September 06, 2013 6:01 PM
> To: Wood Scott-B07421
> Cc: Johnston Michael-R49610; linuxppc-dev at lists.ozlabs.org
> Subject: RE: [PATCH V3 2/2] powerpc/85xx: Add TWR-P1025 board support
> 
> Hi Scott,
> 
> Thanks for your reminding and advice.
> 
> I discuss this with Liu Shengzhou(the first person that remind me #interrupt-
> cells is 4), he advised removing the interrupts property from the phy node,
> because the mdio used the poll way preferentially.
> 
> Best Regards
> Xie Xiaobo
> 
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, September 05, 2013 12:26 AM
> To: Xie Xiaobo-R63061
> Cc: linuxppc-dev at lists.ozlabs.org; galak at kernel.crashing.org; Johnston Michael-
> R49610
> Subject: Re: [PATCH V3 2/2] powerpc/85xx: Add TWR-P1025 board support
> 
> On Mon, 2013-09-02 at 18:11 +0800, Xie Xiaobo wrote:
> > +&soc {
> > +	usb at 22000 {
> > +		phy_type = "ulpi";
> > +	};
> > +
> > +	mdio at 24000 {
> > +		phy0: ethernet-phy at 2 {
> > +			interrupt-parent = <&mpic>;
> > +			interrupts = <1 1>;
> > +			reg = <0x2>;
> > +		};
> > +
> > +		phy1: ethernet-phy at 1 {
> > +			interrupt-parent = <&mpic>;
> > +			interrupts = <2 1>;
> > +			reg = <0x1>;
> > +		};
> 
> Again, #interrupt-cells is 4.
> 
> Please respond to feedback rather than ignoring it and reposting the same thing
> without comment.
> 
> -Scott
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev