[PATCH v3 2/3] powerpc/85xx: Add silicon device tree for C293

[Liu Po-B43644]

>  -----Original Message-----
>  From: Wood Scott-B07421
>  Sent: Wednesday, July 31, 2013 2:28 AM
>  To: Liu Po-B43644
>  Cc: linuxppc-dev at ozlabs.org; galak at kernel.crashing.org; Fleming Andy-
>  AFLEMING; Hu Mingkai-B21284; Liu Po-B43644
>  Subject: Re: [PATCH v3 2/3] powerpc/85xx: Add silicon device tree for
>  C293
>  
>  On 07/30/2013 03:49:22 AM, Po Liu wrote:
>  > From: Mingkai Hu <Mingkai.Hu at freescale.com>
>  >
>  > Signed-off-by: Mingkai Hu <Mingkai.Hu at freescale.com>
>  > Signed-off-by: Po Liu <Po.Liu at freescale.com>
>  > ---
>  > Changes for v2:
>  > 	- None
>  > Changes for v3:
>  > 	- None
>  >
>  >  arch/powerpc/boot/dts/fsl/c293si-post.dtsi | 193
>  > +++++++++++++++++++++++++++++
>  >  arch/powerpc/boot/dts/fsl/c293si-pre.dtsi  |  63 ++++++++++
>  >  2 files changed, 256 insertions(+)
>  >  create mode 100644 arch/powerpc/boot/dts/fsl/c293si-post.dtsi
>  >  create mode 100644 arch/powerpc/boot/dts/fsl/c293si-pre.dtsi
>  >
>  > diff --git a/arch/powerpc/boot/dts/fsl/c293si-post.dtsi
>  > b/arch/powerpc/boot/dts/fsl/c293si-post.dtsi
>  > new file mode 100644
>  > index 0000000..bd20832
>  > --- /dev/null
>  > +++ b/arch/powerpc/boot/dts/fsl/c293si-post.dtsi
>  > @@ -0,0 +1,193 @@
>  > +/*
>  > + * C293 Silicon/SoC Device Tree Source (post include)
>  > + *
>  > + * Copyright 2012 Freescale Semiconductor Inc.
>  > + *
>  > + * Redistribution and use in source and binary forms, with or without
>  > + * modification, are permitted provided that the following
>  > conditions are met:
>  > + *     * Redistributions of source code must retain the above
>  > copyright
>  > + *       notice, this list of conditions and the following
>  > disclaimer.
>  > + *     * Redistributions in binary form must reproduce the above
>  > copyright
>  > + *       notice, this list of conditions and the following
>  > disclaimer in the
>  > + *       documentation and/or other materials provided with the
>  > distribution.
>  > + *     * Neither the name of Freescale Semiconductor nor the
>  > + *       names of its contributors may be used to endorse or promote
>  > products
>  > + *       derived from this software without specific prior written
>  > permission.
>  > + *
>  > + *
>  > + * ALTERNATIVELY, this software may be distributed under the terms
>  > of the
>  > + * GNU General Public License ("GPL") as published by the Free
>  > Software
>  > + * Foundation, either version 2 of that License or (at your option)
>  > any
>  > + * later version.
>  > + *
>  > + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS''
>  > AND ANY
>  > + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>  > IMPLIED
>  > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>  > PURPOSE ARE
>  > + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE
>  > FOR ANY
>  > + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>  > CONSEQUENTIAL DAMAGES
>  > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
>  > OR SERVICES;
>  > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
>  > CAUSED AND
>  > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
>  > LIABILITY, OR TORT
>  > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
>  > USE OF THIS
>  > + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  > + */
>  > +
>  > +&ifc {
>  > +	#address-cells = <2>;
>  > +	#size-cells = <1>;
>  > +	compatible = "fsl,ifc", "simple-bus";
>  > +	interrupts = <19 2 0 0>;
>  > +};
>  > +
>  > +/* controller at 0xa000 */
>  > +&pci0 {
>  > +	compatible = "fsl,qoriq-pcie-v2.2", "fsl,qoriq-pcie";
>  > +	device_type = "pci";
>  > +	#size-cells = <2>;
>  > +	#address-cells = <3>;
>  > +	bus-range = <0 255>;
>  > +	clock-frequency = <33333333>;
>  > +	interrupts = <16 2 0 0>;
>  
>  Remove clock-frequency (surely PCIe is not running at 33 MHz).
>  
>  > +	crypto at 80000 {
>  > +/include/ "qoriq-sec6.0-0.dtsi"
>  > +	};
>  > +
>  > +	crypto at 80000 {
>  > +		reg = <0x80000 0x20000>;
>  > +		ranges = <0x0 0x80000 0x20000>;
>  > +
>  > +		jr at 1000{
>  > +			interrupts = <45 2 0 0>;
>  > +		};
>  > +		jr at 2000{
>  > +			interrupts = <57 2 0 0>;
>  > +		};
>  > +	};
>  
>  Do these inline the way the example shows.
Sorry, Scott, I just remember in this way, the node can't be recognized by system when run Uboot. The include can't be in the crypto at 80000. See the discussion in http://git.am.freescale.net:8181/#/c/736/  .
Maybe I should re-modify the example file.
>  
>  -Scott