[PATCH v2 3/3] powerpc/85xx: Add C293PCIE board support

[Scott Wood]

On 07/28/2013 09:20:11 PM, Liu Po-B43644 wrote:
> 
> 
> >  -----Original Message-----
> >  From: Wood Scott-B07421
> >  Sent: Saturday, July 27, 2013 5:59 AM
> >  To: Liu Po-B43644
> >  Cc: linuxppc-dev at ozlabs.org; galak at kernel.crashing.org; Fleming  
> Andy-
> >  AFLEMING; Hu Mingkai-B21284; Liu Po-B43644
> >  Subject: Re: [PATCH v2 3/3] powerpc/85xx: Add C293PCIE board  
> support
> >
> >  On 07/25/2013 09:41:19 PM, Po Liu wrote:
> >  > +		partition at 1900000 {
> >  > +			/* 7MB for User Area */
> >  > +			reg = <0x01900000 0x00700000>;
> >  > +			label = "NAND User area";
> >  > +		};
> >  > +
> >  > +		partition at 2000000 {
> >  > +			/* 96MB for Root File System */
> >  > +			reg = <0x02000000 0x06000000>;
> >  > +			label = "NAND Root File System";
> >  > +		};
> >  > +
> >  > +		partition at 8000000 {
> >  > +			/* 3968MB for Others */
> >  > +			reg = <0x08000000 0xF8000000>;
> >  > +			label = "NAND Others";
> >  > +		};
> >
> >  Again, what is the difference between "user area" and "others"?   
> I'm not
> >  even sure why it needs to be separate from "root file system", but  
> at
> >  least the root filesystem should be larger given the size of the  
> overall
> >  flash.
> Do you mean just merge up four partition into one "RFS"? Or merge up  
> four partition into "RFS" and "User area" is better?

If you don't have a reason for separating them, then probably yes,  
merge them all into one.  If you do keep RFS and "user area" separate,  
then "user area" should be the larger of the two, but the RFS should be  
more than just 96 MiB.

> >  > +			partition at 580000 {
> >  > +				/* 10.5MB for Compressed RFS  
> Image */
> >  > +				reg = <0x00580000 0x00a80000>;
> >  > +				label = "SPI Flash Compressed  
> RFSImage";
> >  > +			};
> >
> >  Space before "Image".  Why specifiy that it's compressed, versus  
> some
> >  other filesystem type?
> >
> Remove all the "compressed" comments when express the RFS partition?

Yes.

-Scott