[PATCH 4/4] Talitos: fix the issue of dma memory leak
Geanta Neag Horia Ioan-B05471
B05471 at freescale.com
Wed Jul 11 17:09:08 EST 2012
On Tue, 10 Jul 2012 09:00:14 +0300, Qiang Liu <qiang.liu at freescale.com> wrote:
> An error will be happened when test with mass data:
> "DMA-API: device driver tries to sync DMA memory it has not allocated";
> "DMA-API: debugging out of memory - disabling"
> dma mapping memory of request->desc is not released by right device,
> it should be private->dev but not dev;
> Cc: Herbert Xu <herbert at gondor.apana.org.au>
> Cc: David S. Miller <davem at davemloft.net>
> Signed-off-by: Qiang Liu <qiang.liu at freescale.com>
> drivers/crypto/talitos.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index 81f8497..a7da48c 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -264,7 +264,7 @@ static void flush_channel(struct device *dev, int
> ch, int error, int reset_ch)
> status = error;
> - dma_unmap_single(dev, request->dma_desc,
> + dma_unmap_single(priv->dev, request->dma_desc,
> sizeof(struct talitos_desc),
Are you sure this fix applies to the upstream version of talitos?
(i.e. have you encountered the error while running on cryptodev.git ?)
Looks to me this is a fix for the not-upstreamed-yet NAPI patch
(which needs to be reworked according to Dave's feedback).
When you respin the patch series, consider removing this one.
More information about the Linuxppc-dev