[linuxppc-release] [PATCH 4/4] Talitos: fix the issue of dma memory leak

[Liu Qiang-B32616]

> -----Original Message-----
> From: Tabi Timur-B04825
> Sent: Wednesday, July 11, 2012 5:26 AM
> To: Liu Qiang-B32616
> Cc: linux-crypto at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; Herbert
> Xu; Li Yang-R58472; David S. Miller
> Subject: Re: [linuxppc-release] [PATCH 4/4] Talitos: fix the issue of dma
> memory leak
> 
> Qiang Liu wrote:
> > An error will be happened when test with mass data:
> 
> Please don't use the phrase "fix the issue" in patch summaries.  It's
> redundant.
> 
> This patch should be titled,
> 
> "drivers/crypto: fix memory leak in Talitos driver"
> 
> > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index
> > 81f8497..a7da48c 100644
> > --- a/drivers/crypto/talitos.c
> > +++ b/drivers/crypto/talitos.c
> > @@ -264,7 +264,7 @@ static void flush_channel(struct device *dev, int
> ch, int error, int reset_ch)
> >  			else
> >  				status = error;
> >
> > -		dma_unmap_single(dev, request->dma_desc,
> > +		 dma_unmap_single(priv->dev, request->dma_desc,
> 
> You have an indentation problem here.
My fault, I will correct it and resend again. Thanks.

> 
> --
> Timur Tabi
> Linux kernel developer at Freescale