[PATCH] rapidio: apply RX/TX enable to active switch ports only

Bounine, Alexandre Alexandre.Bounine at idt.com
Mon Aug 27 23:01:00 EST 2012


On Friday, August 24, 2012 5:04 PM
Andrew Morton <akpm at linux-foundation.org>
> 
> On Tue, 21 Aug 2012 10:23:55 -0400
> Alexandre Bounine <alexandre.bounine at idt.com> wrote:
> 
>> Modify RIO enumeration to apply RX/TX enable operations only to
>> active switch ports. This will leave inactive ports in condition consistent
>> with their state.
> 
> It's unclear (to me) what the effects of this are.  Does it fix some
> user-visible malfunction?  Or is it just some nice-to-have thing?  Or
> what?
> 

This patch was intended to keep inactive switch ports with inbound and
outbound packet transfers disabled to block unexpected packets during
hot insertion event. While it does not fix any visible malfunction it
was intended to prevent such events in future.   

Since this patch was published it was brought to my attention that some
existing switches may require inbound and outbound ports enabled for
inactive ports as well (not spec compliant).
Therefore, please remove this patch from your tree.     

>> This patch is applicable to kernel versions starting from v2.6.35.
> 
> Is that a recommendation that such a backport be performed?  If so,
> please provide the reasoning.




More information about the Linuxppc-dev mailing list