[RFC V7 PATCH 18/19] memory-hotplug: add node_device_release

wency at cn.fujitsu.com wency at cn.fujitsu.com
Mon Aug 20 19:35:41 EST 2012

From: Yasuaki Ishimatsu <isimatu.yasuaki at jp.fujitsu.com>

When calling unregister_node(), the function shows following message at

Device 'node2' does not have a release() function, it is broken and must be

So the patch implements node_device_release()

CC: David Rientjes <rientjes at google.com>
CC: Jiang Liu <liuj97 at gmail.com>
CC: Len Brown <len.brown at intel.com>
CC: Benjamin Herrenschmidt <benh at kernel.crashing.org>
CC: Paul Mackerras <paulus at samba.org>
CC: Christoph Lameter <cl at linux.com>
Cc: Minchan Kim <minchan.kim at gmail.com>
CC: Andrew Morton <akpm at linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki at jp.fujitsu.com>
Signed-off-by: Wen Congyang <wency at cn.fujitsu.com>
 drivers/base/node.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index af1a177..9bc2f57 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -252,6 +252,13 @@ static inline void hugetlb_register_node(struct node *node) {}
 static inline void hugetlb_unregister_node(struct node *node) {}
+static void node_device_release(struct device *dev)
+	struct node *node_dev = to_node(dev);
+	flush_work(&node_dev->node_work);
+	memset(node_dev, 0, sizeof(struct node));
  * register_node - Setup a sysfs device for a node.
@@ -265,6 +272,7 @@ int register_node(struct node *node, int num, struct node *parent)
 	node->dev.id = num;
 	node->dev.bus = &node_subsys;
+	node->dev.release = node_device_release;
 	error = device_register(&node->dev);
 	if (!error){

More information about the Linuxppc-dev mailing list