[PATCH] powerpc/fsl: mpic timer driver

Kumar Gala galak at kernel.crashing.org
Wed Aug 1 00:31:04 EST 2012


On Jul 31, 2012, at 2:58 AM, Wang Dongsheng-B40534 wrote:

> 
> 
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak at kernel.crashing.org]
>> Sent: Friday, July 27, 2012 9:14 PM
>> To: Wang Dongsheng-B40534
>> Cc: benh at kernel.crashing.org; paulus at samba.org; Wood Scott-B07421;
>> linuxppc-dev at lists.ozlabs.org
>> Subject: Re: [PATCH] powerpc/fsl: mpic timer driver
>> 
>> 
>> On Jul 27, 2012, at 1:20 AM, <Dongsheng.wang at freescale.com>
>> <Dongsheng.wang at freescale.com> wrote:
>> 
>>> From: Wang Dongsheng <Dongsheng.Wang at freescale.com>
>>> 
>>> Global timers A and B internal to the PIC. The two independent groups
>>> of global timer, group A and group B, are identical in their
>> functionality.
>>> The hardware timer generates an interrupt on every timer cycle.
>>> e.g
>>> Power management can use the hardware timer to wake up the machine.
>>> 
>>> Signed-off-by: Wang Dongsheng <Dongsheng.Wang at freescale.com>
>>> Signed-off-by: Li Yang <leoli at freescale.com>
>> 
>> How much of this is FSL specific vs openpic?  OpenPIC spec's timer
>> support (only a single group).
>> 
> [Wang Dongsheng] Yes, OpenPIC only a single group timer.
> FSL: add more register, features and group.
> This patch only to support FSL chip.
> "mpic_timer.c" -> "fsl_mpic_timer.c"
> I will modify the description of the patch. how about?

I'd rather we support both, can we not use the MPIC_FSL flag to deal with FSL specific behavior?

- k



More information about the Linuxppc-dev mailing list