[EDAC PATCH v13 2/7] edac: move dimm properties to struct dimm_info

Borislav Petkov bp at amd64.org
Fri Apr 27 00:26:52 EST 2012


On Mon, Apr 16, 2012 at 05:12:08PM -0300, Mauro Carvalho Chehab wrote:
> On systems based on chip select rows, all channels need to use memories
> with the same properties, otherwise the memories on channels A and B
> won't be recognized.
> 
> However, such assumption is not true for all types of memory
> controllers.
> 
> Controllers for FB-DIMM's don't have such requirements.
> 
> Also, modern Intel controllers seem to be capable of handling such
> differences.
> 
> So, we need to get rid of storing the DIMM information into a per-csrow
> data, storing it, instead at the right place.
> 
> The first step is to move grain, mtype, dtype and edac_mode to the
> per-dimm struct.
> 
> Reviewed-by: Aristeu Rozanski <arozansk at redhat.com>
> Cc: Doug Thompson <norsk5 at yahoo.com>
> Cc: Borislav Petkov <borislav.petkov at amd.com>
> Cc: Mark Gross <mark.gross at intel.com>
> Cc: Jason Uhlenkott <juhlenko at akamai.com>
> Cc: Tim Small <tim at buttersideup.com>
> Cc: Ranganathan Desikan <ravi at jetztechnologies.com>
> Cc: "Arvind R." <arvino55 at gmail.com>
> Cc: Olof Johansson <olof at lixom.net>
> Cc: Egor Martovetsky <egor at pasemi.com>
> Cc: Chris Metcalf <cmetcalf at tilera.com>
> Cc: Michal Marek <mmarek at suse.cz>
> Cc: Jiri Kosina <jkosina at suse.cz>
> Cc: Joe Perches <joe at perches.com>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov at gmail.com>
> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Cc: Hitoshi Mitake <h.mitake at gmail.com>
> Cc: Andrew Morton <akpm at linux-foundation.org>
> Cc: James Bottomley <James.Bottomley at parallels.com>
> Cc: "Niklas Söderlund" <niklas.soderlund at ericsson.com>
> Cc: Shaohui Xie <Shaohui.Xie at freescale.com>
> Cc: Josh Boyer <jwboyer at gmail.com>
> Cc: Mike Williams <mike at mikebwilliams.com>
> Cc: linuxppc-dev at lists.ozlabs.org
> Signed-off-by: Mauro Carvalho Chehab <mchehab at redhat.com>

For the amd64_edac and core changes:

Reviewed-by: Borislav Petkov <borislav.petkov at amd.com>

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551


More information about the Linuxppc-dev mailing list