[PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay

Kumar Gala kumar.gala at freescale.com
Thu Sep 1 14:42:08 EST 2011


On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote:

> The mmc_delay() is a wrapper function for mdelay() and msleep().
> 
>    o mdelay() -- block the system when busy-waiting.
>    o msleep() -- suspend the currently running task to enable CPU
>                  to process other tasks, so it is non-blocking
>                  regarding the whole system.
> 
> When the desired delay time is more than a period of timer interrupt,
> just use msleep(). Change mdelay() to mmc_delay() to avoid chewing
> CPU when busy wait.
> 
> Signed-off-by: Shengzhou Liu <b36685 at freescale.com>
> Signed-off-by: Chunhe Lan <Chunhe.Lan at freescale.com>
> Cc: Chris Ball <cjb at laptop.org>
> ---
> drivers/mmc/host/sdhci.c |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)

It might be good to either merge patch 2/3 & 3/3 or rename them since they have same commit message.

Chris,

Any comments on closing on these patches?

- k


More information about the Linuxppc-dev mailing list