[RFC][PATCH 28/30] powerpc/85xx: Rework P1023RDS device tree

Scott Wood scottwood at freescale.com
Fri Nov 11 05:55:59 EST 2011


On Thu, Nov 10, 2011 at 12:42:54PM -0600, Kumar Gala wrote:
> 
> On Nov 10, 2011, at 12:10 PM, Scott Wood wrote:
> 
> > On Thu, Nov 10, 2011 at 10:14:11AM -0600, Kumar Gala wrote:
> >> -		power at e0070{
> >> -			compatible = "fsl,mpc8536-pmc", "fsl,mpc8548-pmc",
> >> -			             "fsl,p1022-pmc";
> >> -			reg = <0xe0070 0x20>;
> >> -			etsec1_clk: soc-clk at B0{
> >> -				fsl,pmcdr-mask = <0x00000080>;
> >> -			};
> >> -			etsec2_clk: soc-clk at B1{
> >> -				fsl,pmcdr-mask = <0x00000040>;
> >> -			};
> >> -			etsec3_clk: soc-clk at B2{
> >> -				fsl,pmcdr-mask = <0x00000020>;
> >> -			};
> >> -		};
> > 
> > The compatibles on this node are wrong, but it looks like you're removing
> > it altogether?
> > 
> > -Scott
> 
> Yeah, I think the whole thing needs to be relocated at because there are no etsec's on P1023, etc.  So will comment about this in commit message

Ah right, the etsec stuff should go as well. :-)

It should look like this:

	power at e0070 {
		compatible = "fsl,p1023-pmc", "fsl,mpc8548-pmc";
		reg = <0xe0070 0x20>;
	};

-Scott



More information about the Linuxppc-dev mailing list