[RFC][PATCH 15/30] powerpc/85xx: Rework P1022DS device tree

[Tabi Timur-B04825]

On Thu, Nov 10, 2011 at 10:13 AM, Kumar Gala <galak at kernel.crashing.org> wrote:
>
>  arch/powerpc/boot/dts/fsl/p1022si-post.dtsi |  235 +++++++++++++++
>  arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi  |   68 +++++
>  arch/powerpc/boot/dts/p1022ds.dts           |  431 +--------------------------
>  3 files changed, 318 insertions(+), 416 deletions(-)
>  create mode 100644 arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
>  create mode 100644 arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi

I understand the value of removing duplication of DTS contents, so
that we don't copy-paste the same nodes over and over again, but now
that you've added pre- and post- dtsi files, I wonder if you're not
jumping out of the frying pan and into the flame.  It seems that the
DTS files are more fragile than ever, and it's more difficult now to
figure out which files go where.

Another concern I have is whether this will force all Pxxxx boards to
have the same CCSR address.  I don't think so, because I didn't see
it, but I just want to make sure.

-- 
Timur Tabi
Linux kernel developer at Freescale