[PATCH 1/2] misc: add CARMA DATA-FPGA Access Driver
davej at redhat.com
Wed Feb 9 04:29:11 EST 2011
On Tue, Feb 08, 2011 at 09:20:46AM -0800, Ira W. Snyder wrote:
> > > +static DEVICE_ATTR(enable, S_IWUGO | S_IRUGO, data_en_show, data_en_set);
> > Are all of these really needed or most of them are for debug?
> Most are for debugging. They have proved useful a few times in
> production to track down bugs.
File mode should probably not be world writable.
(checkpatch.pl should warn you about this now btw)
More information about the Linuxppc-dev