[PATCH 3/3] powerpc: icswx: Simple ACOP fault handler for both book3e and book3s parts.

[Jimi Xenidis]

On Aug 9, 2011, at 10:15 AM, Benjamin Herrenschmidt wrote:

> On Tue, 2011-08-09 at 00:26 -0500, Kumar Gala wrote:
> 
>>> +	/* Some implementations leave us a hint for the CT */
>>> +	ct = ICSWX_GET_CT_HINT(error_code);
>>> +	if (ct < 0) {
>>> +		/* we have to peek at the instruction work to figure out CT */
>>> +		union cop_ccw ccw;
>> 
>> don't use a union, we don't do this for any other place we decode instructions (just use shift/mask).  Utilize ppc-opcode.h
> 
> Except that the union here is -not- the instruction, but the content of
> the RS register :-)

I agree, especially for when we need the kernel to build the struct/union.
However, that is a later patch (working on it now and if there are no objections) so I'll add it then.
-JX

> 
> Cheers,
> Ben.
> 
>