[PATCH 3/3] powerpc: icswx: Simple ACOP fault handler for both book3e and book3s parts.

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Aug 10 01:15:29 EST 2011


On Tue, 2011-08-09 at 00:26 -0500, Kumar Gala wrote:

> > +	/* Some implementations leave us a hint for the CT */
> > +	ct = ICSWX_GET_CT_HINT(error_code);
> > +	if (ct < 0) {
> > +		/* we have to peek at the instruction work to figure out CT */
> > +		union cop_ccw ccw;
> 
> don't use a union, we don't do this for any other place we decode instructions (just use shift/mask).  Utilize ppc-opcode.h

Except that the union here is -not- the instruction, but the content of
the RS register :-)

Cheers,
Ben.




More information about the Linuxppc-dev mailing list