[PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
wd at denx.de
Tue Sep 21 07:31:26 EST 2010
Dear Tirumala Marri,
In message <7707889dee57e97ad50b4ce5c7697466 at mail.gmail.com> you wrote:
> > > +/**
> > > + * ppc440spe_can_rxor - check if the operands may be processed with RXOR
> > > + */
> > > +static int ppc440spe_can_rxor(struct page **srcs, int src_cnt,
> > size_t len)
> > Again, should this then not be in ppc440spe specific files?
> > It seems the split / generalization is highly incomplete yet.
> [Marri] Some of the stuff can go into ppc440spe-dma.h. This is just
> Beginning to add more new DMA engines support. I expect more changes to
> come in.
Why would that go into a header file? This is source code, not header
stuff. It should stay in a .c file! [Note that Ilya asked the same
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Intel's new motto: United we stand. Divided we fall!
More information about the Linuxppc-dev