[PATCH 1/2] PPC4xx: Generelizing drivers/dma/ppc4xx/adma.c
tmarri at apm.com
Tue Sep 21 04:00:03 EST 2010
> Will this driver ever include any 40x processors? If not, you probably
> should use "44x" instead (here and everywhere in the rest of the
[Marri] Yes there is 40x based DMA engine we planned to include in the
> > +/* Pointer to DMA0, DMA1 CP/CS FIFO */
> > +static void *ppc440spe_dma_fifo_buf;
> Seems this should go into "ppc440spe-dma.h"?
> > +/* This array is used in data-check operations for storing a pattern
> > +static char ppc440spe_qword;
> > +
> > +static atomic_t ppc4xx_adma_err_irq_ref;
> > +static dcr_host_t ppc440spe_mq_dcr_host;
> > +static unsigned int ppc440spe_mq_dcr_len;
> > +static unsigned long ppc440spe_rxor_state;
> > +
> > +static struct page *ppc440spe_rxor_srcs;
> And here again - please check globally!
> > +/**
> > + * ppc440spe_can_rxor - check if the operands may be processed with
> > + */
> > +static int ppc440spe_can_rxor(struct page **srcs, int src_cnt,
> size_t len)
> Again, should this then not be in ppc440spe specific files?
> It seems the split / generalization is highly incomplete yet.
[Marri] Some of the stuff can go into ppc440spe-dma.h. This is just
Beginning to add more new DMA engines support. I expect more changes to
More information about the Linuxppc-dev