Problem of PowerPc 82xx when using smc

Scott Wood scottwood at freescale.com
Fri May 21 03:06:08 EST 2010


On Thu, May 20, 2010 at 04:58:27PM +0800, hellohello wrote:
> 
> I find a problem in 
> drivers/serial/cpm_uart/cpm_uart_cpm2.c:
> int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)
> {
> ... ...
> pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos;
> /*The above line should be :*/
>  pinfo->tx_bd_base = pinfo->rx_bd_base + sizeof(cbd_t) * pinfo->rx_nrfifos;

No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication
already happens as part of pointer arithmetic.

> return 0;
> }
> 
> Where to get the newest code for kernel?

git.kernel.org

> How to know whether it is already patched by anyone else?  Just search in  this mail list?

As well as the current git tree.

-Scott


More information about the Linuxppc-dev mailing list