[PATCH] [V2] net: emaclite: adding MDIO and phy lib support

[John Linn]

> -----Original Message-----
> From: glikely at secretlab.ca [mailto:glikely at secretlab.ca] On Behalf Of Grant Likely
> Sent: Tuesday, February 09, 2010 8:45 AM
> To: John Linn
> Cc: netdev at vger.kernel.org; linuxppc-dev at ozlabs.org; jgarzik at pobox.com; jwboyer at linux.vnet.ibm.com;
> john.williams at petalogix.com; Sadanand Mutyala
> Subject: Re: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support
> 
> On Mon, Feb 8, 2010 at 7:09 AM, John Linn <John.Linn at xilinx.com> wrote:
> >> -----Original Message-----
> >> From: John Linn [mailto:john.linn at xilinx.com]
> >> Sent: Friday, February 05, 2010 3:41 PM
> >> To: netdev at vger.kernel.org; linuxppc-dev at ozlabs.org;
> > jgarzik at pobox.com; grant.likely at secretlab.ca;
> >> jwboyer at linux.vnet.ibm.com
> >> Cc: john.williams at petalogix.com; John Linn; Sadanand Mutyala
> >> Subject: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support
> >>
> >> These changes add MDIO and phy lib support to the driver as the
> >> IP core now supports the MDIO bus.
> >>
> >> The MDIO bus and phy are added as a child to the emaclite in the
> > device
> >> tree as illustrated below.
> >>
> >> mdio {
> >>       #address-cells = <1>;
> >>       #size-cells = <0>;
> >>       compatible = "xlnx,emaclite-mdio";
> >>       phy0: phy at 7 {
> >>               reg = <7>;
> >>       } ;
> >> }
> 
> You misunderstood me about the compatible property.  You don't need a
> compatible prop in the mdio node because it is *alwasy* a child of the
> emaclite node, and the emaclite driver knows to go looking for it (ie.
> it is a part of the device).

OK, now I see, sorry for my denseness there.

> 
> What I want to see is a compatible value in the phy at 7 node for the
> make & model of the phy.

Makes more sense.

> 
> Otherwise, looks good to me.  Fix the mutex timeout problem and then
> you can add my acked-by line to the patch.

Will spin V3 patch with fixes and add your ack, appreciate the help and your patience.

- John

> 
> Cheers,
> g.


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.