[PATCH] [V2] net: emaclite: adding MDIO and phy lib support

[Grant Likely]

On Mon, Feb 8, 2010 at 7:09 AM, John Linn <John.Linn at xilinx.com> wrote:
>> -----Original Message-----
>> From: John Linn [mailto:john.linn at xilinx.com]
>> Sent: Friday, February 05, 2010 3:41 PM
>> To: netdev at vger.kernel.org; linuxppc-dev at ozlabs.org;
> jgarzik at pobox.com; grant.likely at secretlab.ca;
>> jwboyer at linux.vnet.ibm.com
>> Cc: john.williams at petalogix.com; John Linn; Sadanand Mutyala
>> Subject: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support
>>
>> These changes add MDIO and phy lib support to the driver as the
>> IP core now supports the MDIO bus.
>>
>> The MDIO bus and phy are added as a child to the emaclite in the
> device
>> tree as illustrated below.
>>
>> mdio {
>>       #address-cells = <1>;
>>       #size-cells = <0>;
>>       compatible = "xlnx,emaclite-mdio";
>>       phy0: phy at 7 {
>>               reg = <7>;
>>       } ;
>> }

You misunderstood me about the compatible property.  You don't need a
compatible prop in the mdio node because it is *alwasy* a child of the
emaclite node, and the emaclite driver knows to go looking for it (ie.
it is a part of the device).

What I want to see is a compatible value in the phy at 7 node for the
make & model of the phy.

Otherwise, looks good to me.  Fix the mutex timeout problem and then
you can add my acked-by line to the patch.

Cheers,
g.