[PATCH] powerpc: remove fpscr use from [kvm_]cvt_{fd,df}

Michael Neuling mikey at neuling.org
Tue Aug 24 15:51:26 EST 2010


> >> Neither lfs nor stfs touch the fpscr, so remove the restore/save of =
> it
> >> around them.
> >=20
> > Do some 32 bit processors need this?=20
> >=20
> > In 32 bit before the merge, we use to have code that did:
> >=20
> >  #if defined(CONFIG_4xx) || defined(CONFIG_E500)
> >   #define cvt_fd without save/restore fpscr
> >  #else
> >   #define cvt_fd with save/restore fpscr
> >  #end if
> >=20
> > Kumar; does this ring any bells?
> >=20
> > (The addition of this predates even bitkeeper)
> >=20
> > Mikey
> 
> Not really.  However if the ifdef is as you say that seems wrong to
> me.  We should be using CONFIG_PPC_FPU or !CONFIG_PPC_FPU.  As both
> 4xx and E500 have variants w/FPUs.

It actually got changed to CONFIG_PPC_FPU, then dwg merged it with some
other versions that were around.  

Mikey


More information about the Linuxppc-dev mailing list