[PATCH] powerpc: remove fpscr use from [kvm_]cvt_{fd,df}

Kumar Gala galak at kernel.crashing.org
Tue Aug 24 15:47:05 EST 2010


On Aug 22, 2010, at 7:23 PM, Michael Neuling wrote:

>> Neither lfs nor stfs touch the fpscr, so remove the restore/save of it
>> around them.
> 
> Do some 32 bit processors need this? 
> 
> In 32 bit before the merge, we use to have code that did:
> 
>  #if defined(CONFIG_4xx) || defined(CONFIG_E500)
>   #define cvt_fd without save/restore fpscr
>  #else
>   #define cvt_fd with save/restore fpscr
>  #end if
> 
> Kumar; does this ring any bells?
> 
> (The addition of this predates even bitkeeper)
> 
> Mikey

Not really.  However if the ifdef is as you say that seems wrong to me.  We should be using CONFIG_PPC_FPU or !CONFIG_PPC_FPU.  As both 4xx and E500 have variants w/FPUs.

- k


More information about the Linuxppc-dev mailing list