[PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52

[Grant Likely]

On Wed, Oct 7, 2009 at 3:49 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
> On Wed, Oct 07, 2009 at 08:40:37AM +0200, Heiko Schocher wrote:
>> - serial Console on PSC1
>> - 64MB SDRAM
>> - MTD CFI Flash
>> - Ethernet FEC
>> - IDE support
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>
> Sorry for finding things incrementally, but I think there is still one issue
> left. Once this is sorted out, you could add my:
>
> Reviewed-by: Wolfram Sang <w.sang at pengutronix.de>
>
[...]
>> +     soc5200 at f0000000 {
>> +             #address-cells = <1>;
>> +             #size-cells = <1>;
>> +             compatible = "fsl,mpc5200-immr",
>> +                             "fsl,mpc5200b-immr";
>
> You should decide on the latter one only here.

Besides, the order is wrong.  The exact version (mpc5200b) always
appears before the list of backward compatible values (the non-'b'
version).  But Wolfram is right.  The IMMR node of the mpc5200b is
*not* wholly backwards compatible with fsl,mpc5200-immr, so
'fsl,mpc5200-immr' should not be in the list.  fsl,mpc5200-<blah> only
appears in the child nodes when the specific device truly is backwards
compatible.  Compare your .dts file line-for-line with one of the
in-tree mpc5200b .dts files.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.