[PATCH] PPC: Sync guest visible MMU state

Avi Kivity avi at redhat.com
Thu Nov 26 23:50:36 EST 2009


On 11/26/2009 02:46 PM, Alexander Graf wrote:
>
>> Please avoid unnamed unions in user-visible headers - they're a gcc
>> extension.
>>
>> Yes, we have them elsewhere, but let's not add to the pile.
>>      
> I'm open to scalable suggestions that don't break existing userspace code.
> If I name the union now, existing qemu code will break. If I align the
> pad array manually I'll definitely mess up something.
>    

You can keep pvr out of the (named) union.

-- 
error compiling committee.c: too many arguments to function



More information about the Linuxppc-dev mailing list