[PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

Kalra Ashish-B00888 ashish.kalra at freescale.com
Thu Jul 30 23:23:17 EST 2009


Hello, 

>> Signed-off-by: Ashish Kalra <Ashish.Kalra at freescale.com>
>> ---
>> drivers/ata/sata_fsl.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
>> index 5a88b44..a33f130 100644
>> --- a/drivers/ata/sata_fsl.c
>> +++ b/drivers/ata/sata_fsl.c
>> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {
>> static struct ata_port_operations sata_fsl_ops = {
>> .inherits = &sata_pmp_port_ops,
>>
>> + .qc_defer = ata_std_qc_defer;
>> .qc_prep = sata_fsl_qc_prep,
>> .qc_issue = sata_fsl_qc_issue,
>> .qc_fill_rtf = sata_fsl_qc_fill_rtf,

> This doesn't look like it should change anything. sata_fsl_ops inherits
> from sata_pmp_port_ops, which inherits from sata_port_ops, which already
> sets qc_defer to ata_std_qc_defer.

Oh, yes. Actually this patch was for older kernels where there inheritence was not there. As you mentioned, this patch is not required now.

Thanks,

Ashish



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20090730/b0d95952/attachment.htm>


More information about the Linuxppc-dev mailing list