<HTML dir=ltr><HEAD><TITLE>Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active</TITLE>
<META http-equiv=Content-Type content="text/html; charset=unicode">
<META content="MSHTML 6.00.2900.3562" name=GENERATOR></HEAD>
<BODY>
<DIV id=idOWAReplyText21890 dir=ltr>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>Hello, </FONT></DIV></DIV>
<DIV dir=ltr><BR><FONT size=2>>> Signed-off-by: Ashish Kalra <Ashish.Kalra@freescale.com><BR>>> ---<BR>>> drivers/ata/sata_fsl.c | 1 +<BR>>> 1 files changed, 1 insertions(+), 0 deletions(-)<BR>>><BR>>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c<BR>>> index 5a88b44..a33f130 100644<BR>>> --- a/drivers/ata/sata_fsl.c<BR>>> +++ b/drivers/ata/sata_fsl.c<BR>>> @@ -1262,6 +1262,7 @@ static struct scsi_host_template sata_fsl_sht = {<BR>>> static struct ata_port_operations sata_fsl_ops = {<BR>>> .inherits = &sata_pmp_port_ops,<BR>>><BR>>> + .qc_defer = ata_std_qc_defer;<BR>>> .qc_prep = sata_fsl_qc_prep,<BR>>> .qc_issue = sata_fsl_qc_issue,<BR>>> .qc_fill_rtf = sata_fsl_qc_fill_rtf,<BR><BR>> This doesn't look like it should change anything. sata_fsl_ops inherits<BR>> from sata_pmp_port_ops, which inherits from sata_port_ops, which already<BR>> sets qc_defer to ata_std_qc_defer.</FONT></DIV>
<P><FONT size=2>Oh, yes. Actually this patch was for older kernels where there inheritence was not there. As you mentioned, this patch is not required now.</FONT></P>
<P><FONT size=2>Thanks,</FONT></P>
<P><FONT size=2>Ashish</FONT></P>
<DIV dir=ltr><FONT size=2><BR></FONT></DIV></BODY></HTML>