[PATCH] powerpc/83xx: Revive Marvell PHY option onMPC8313E-RDB rev. C boards

[Li Yang-R58472]

> -----Original Message-----
> From: Anton Vorontsov [mailto:avorontsov at ru.mvista.com] 
> Sent: Friday, February 13, 2009 9:18 AM
> To: Kumar Gala
> Cc: linuxppc-dev list; Li Yang-R58472
> Subject: Re: [PATCH] powerpc/83xx: Revive Marvell PHY option 
> onMPC8313E-RDB rev. C boards
> 
> On Thu, Feb 12, 2009 at 05:51:57PM -0600, Kumar Gala wrote:
> > On Feb 11, 2009, at 11:40 PM, Li Yang-R58472 wrote:
> >>>> Li, thanks for heads-up!
> >>>>
> >>>> One thing though: documentation says that Marvell PHY
> >>> address is 0x3,
> >>>> while old device tree and this patch:
> >>>>
> >>>>
> >>> http://www.bitshrine.org/gpp/linux-fsl-2.6.23-MPC8313ERDB-add-
> >>> default-
> >>>> dts.patch
> >>>>
> >>>> says "0x1"... I don't have any rev. C boards, so it would
> >>> be great if
> >>>> somebody could confirm that 0x1 is the actual address.
> >>
> >> The correct address is 0x3.  The previous patch in revB BSP used a 
> >> guess value before the revC documentation is available.  
> The latest 
> >> BSP has been updated to use the correct address.
> >
> > Anton, will you spin a new patch with this change?
> 
> Since the correct address is 0x3, that means that the old 
> device tree never worked on rev. C boards, thus there is no 
> regression.
> And furthermore, it appears that U-Boot doesn't support 
> Marvell PHY option either.

No regression but to be more updated.  RevC boards are newly introduced.

> 
> So, I don't think that adding the new device tree makes any sense now.
> 
> I think the better option would be to implement Marvell PHY 
> support in U-Boot, and at the same time teach U-Boot to fixup 
> 8313rdb's device tree depending on the environment variable 
> (something like setenv marvell_phy_option yes/no), i.e. like 
> I did for MPC8315E-RDB's ULPI/TSEC1 options:
> 
> http://lists.denx.de/pipermail/u-boot/2008-July/036553.html

This approach is surely more user friendly.

- Leo