[PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Dec 1 18:29:05 EST 2009

On Tue, 2009-12-01 at 16:25 +0900, Tejun Heo wrote:
> On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote:
> > In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop()
> > instead of ap->ops->bmdma_stop(). This can be a problem for controllers
> > that use their own bmdma_stop for which the generic sff one isn't suitable
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Oh... that's a scary bug lurking around.  Thanks for catching it.
> Acked-by: Tejun Heo <tj at kernel.org>

Feel free to pick that one up earlier if you want (ie for 2.6.32), as
long as we manage to get it in in 2.6.33 -before- I push powerpc-next to
Linus, I'm happy :-) (or we can have it in both trees).


More information about the Linuxppc-dev mailing list