[PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()

Tejun Heo tj at kernel.org
Tue Dec 1 18:25:16 EST 2009


On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote:
> In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop()
> instead of ap->ops->bmdma_stop(). This can be a problem for controllers
> that use their own bmdma_stop for which the generic sff one isn't suitable
> 
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Oh... that's a scary bug lurking around.  Thanks for catching it.

Acked-by: Tejun Heo <tj at kernel.org>

-- 
tejun


More information about the Linuxppc-dev mailing list