[ewg] [PATCH] IB/ehca: Construct MAD redirect replies from request MAD
hal.rosenstock at gmail.com
Thu Aug 27 23:31:40 EST 2009
On 8/27/09, Joachim Fenkes <FENKES at de.ibm.com> wrote:
> Hal Rosenstock <hal.rosenstock at gmail.com> wrote on 26.08.2009 17:15:03:
> > Thanks for doing this. It looks sane to me. The only issue I recall that
> > appears to be remaining is a better setting of
> > rather than hardcoding. Perhaps using the value from PortInfo is the way
> to go
> > (ideally it would be that value from the port to which the the requester
> > being redirected to but that might not be so easy to get from this port.
> I don't think that effort will be necessary or even legal. The requestor
> will react to the redirection with another Get(ClassPortInfo) to the
> redirection target, which will reply with its own RespTimeValue, so our
> driver should speak for itself.
I overreached with my comment on how this works.
Since we don't know when our MAD
> processing and sending of the response is going to be scheduled (we're not
> running on real-time constraints here), we play it safe and return 18,
> which amounts to roughly a second.
> Make sense?
I don't think it should be hard coded. IMO it would be better to default to
18 and somehow able to be adjusted (via a (dynamic) module parameter ?).
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Linuxppc-dev