[PATCH] uninorth agp: don't mark module parameter __devinit
Michel Dänzer
michel at tungstengraphics.com
Thu Oct 30 03:34:04 EST 2008
On Wed, 2008-10-29 at 13:12 +0100, Johannes Berg wrote:
> On Wed, 2008-10-29 at 13:09 +0100, Michel Dänzer wrote:
> > On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote:
> > > A module parameter can possibly be shown via sysfs, which isn't a good
> > > idea if the section has been removed, so remove the __devinit
> > > annotation.
> >
> > Under what circumstances could it be shown in sysfs?
>
> Sorry, my mistake, I overlooked that it had 0 permission:
> module_param(aperture, charp, 0);
>
> otherwise it would of course be in sysfs.
>
> Can uninorth_fetch_size be marked __devinit then?
I'm not sure, and none of the other AGP backend drivers seems to do
so...
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
More information about the Linuxppc-dev
mailing list