[PATCH] uninorth agp: don't mark module parameter __devinit

Johannes Berg johannes at sipsolutions.net
Wed Oct 29 23:12:59 EST 2008


On Wed, 2008-10-29 at 13:09 +0100, Michel Dänzer wrote:
> On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote:
> > A module parameter can possibly be shown via sysfs, which isn't a good
> > idea if the section has been removed, so remove the __devinit
> > annotation.
> 
> Under what circumstances could it be shown in sysfs?

Sorry, my mistake, I overlooked that it had 0 permission:
module_param(aperture, charp, 0);

otherwise it would of course be in sysfs.

Can uninorth_fetch_size be marked __devinit then?

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20081029/f651f580/attachment.pgp>


More information about the Linuxppc-dev mailing list